core(fr): use frame url in gather context #13699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
connorjclark
approved these changes
Feb 25, 2022
Robert98MG
added a commit
to Robert98MG/lighthouse
that referenced
this pull request
Feb 26, 2022
This reverts commit 74bf436.
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In legacy navigations
context.urlis the current frame URL and is unaffected by the history API.However in FR navigations,
context.urlis the result ofpage.url()from Puppeteer and is affected by the history API. This can lead to issues in FR navigations where we try and usecontext.urlto get the main document, butcontext.urlis not the URL used to fetch the main document.This PR ensures
context.urlreflects the current frame URL without considering any history API calls once we reach thegetArtifactphase.Once we deprecate the legacy navigation runner, I think we should deprecate
context.url. Then we can usecontext.baseArtifacts.URLto get the frame URL andcontext.driver.url()to get the URL affected by history API.